This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(views): make sure domain is set it in cert attach operation#1046
Merged
helgi merged 1 commit intodeis:masterfrom Sep 9, 2016
Merged
fix(views): make sure domain is set it in cert attach operation#1046helgi merged 1 commit intodeis:masterfrom
helgi merged 1 commit intodeis:masterfrom
Conversation
|
@bacongobbler, @Joshua-Anderson and @mboersma are potential reviewers of this pull request based on my analysis of |
Made it so a user can pass /v2/apps/foo/domains/thing.com or pass {domain: thing.com} as the body
This works because DELETE uses the former format and POST (including SDK) use the latter but the URL format supports POST doing both... Should probably drop the body element at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so a user can pass /v2/apps/foo/domains/thing.com or pass {domain: thing.com} as the body
This works because DELETE uses the former format and POST (including SDK) use the latter but the URL format supports POST doing both... Should probably drop the body element at some point when we can break the API